This repository was archived by the owner on Nov 26, 2024. It is now read-only.
Replace Flask's url_for with app_template_url_for#430
Open
rnagle wants to merge 5 commits intonprapps:masterfrom
Open
Replace Flask's url_for with app_template_url_for#430rnagle wants to merge 5 commits intonprapps:masterfrom
rnagle wants to merge 5 commits intonprapps:masterfrom
Conversation
…path prefix when rendering for staging or production
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app_template_url_foris a little helper function that takes into account the deployment target when building urls. It inserts the project's slug/path prefix when building for staging or prod.Note that I'm overriding Flask's
url_forwithapp_template_url_forin app.py.Also added
static_folder='www/assets'to the Flask instance so that{{ url_for('static', filename="some_file.png") }}works properly when some_file.png is in www/assets/.I wrote this because I couldn't find a way to configure the Flask object to do this for me. Maybe I'm missing something. Let me know what you think!